Re: [PATCH v8 10/41] richacl: Permission check algorithm

From: Andreas GrÃnbacher
Date: Mon Sep 28 2015 - 12:51:58 EST


2015-09-28 18:29 GMT+02:00 J. Bruce Fields <bfields@xxxxxxxxxxxx>:
> On Mon, Sep 28, 2015 at 06:25:23PM +0200, Andreas GrÃnbacher wrote:
>> 2015-09-28 18:08 GMT+02:00 J. Bruce Fields <bfields@xxxxxxxxxxxx>:
>> > The above also skips the following group_mask application on any unix
>> > group.
>>
>> Really? How does it do that?
>
> Sorry, I meant "unix user", not "unix group"!

Indeed, that's a bit tricky. Probably worth changing if just for clarity:

- goto entry_matches_owner;
+ if (uid_eq(current_fsuid(), inode->i_uid))
+ goto entry_matches_owner;

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/