Re: [PATCH v2 3/4] perf tools: Adds the tracepoint name parsing support
From: Jiri Olsa
Date: Sun Sep 27 2015 - 16:35:11 EST
On Fri, Sep 25, 2015 at 11:11:50AM +0000, He Kuang wrote:
> Adds rules for parsing tracepoint names. Change rules of tracepoint
> which derives of PE_NAMEs into tracepoint names directly, so adding
> more rules based on tracepoint names will be easier.
>
> Signed-off-by: He Kuang <hekuang@xxxxxxxxxx>
> ---
> tools/perf/util/parse-events.y | 38 +++++++++++++++++++++++---------------
> 1 file changed, 23 insertions(+), 15 deletions(-)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 8bcc458..279c01c 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -67,6 +67,7 @@ static inc_group_count(struct list_head *list,
> %type <head> event_legacy_cache
> %type <head> event_legacy_mem
> %type <head> event_legacy_tracepoint
> +%type <tracepoint_name> __event_legacy_tracepoint
> %type <head> event_legacy_numeric
> %type <head> event_legacy_raw
> %type <head> event_def
> @@ -84,6 +85,10 @@ static inc_group_count(struct list_head *list,
> u64 num;
> struct list_head *head;
> struct parse_events_term *term;
> + struct tracepoint_name{
^^^ missing space
you could use scripts/checkpatch.pl and follow some of the recomendations
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/