Re: [PATCH] powercap / RAPL : remove dependency on iosf_mbi

From: Pengyu Ma
Date: Fri Sep 25 2015 - 23:43:39 EST


$ objdump --dwarf drivers/powercap/intel_rapl.o |grep iosf
<65ad> DW_AT_name : (indirect string, offset: 0x3644): iosf_mbi_read
<65f7> DW_AT_name : (indirect string, offset: 0x496): iosf_mbi_write
5 3 0 0 iosf_mbi.h
0x00000490 656c5f69 6400696f 73665f6d 62695f77 el_id.iosf_mbi_w
0x00003640 72656700 696f7366 5f6d6269 5f726561 reg.iosf_mbi_rea

$ grep -i iosf_mbi .config
# CONFIG_IOSF_MBI is not set

It is compiled and included by header file.

Pengyu

On 09/25/2015 12:33 AM, Jacob Pan wrote:
On Thu, 24 Sep 2015 18:03:32 +0800
Pengyu Ma <pengyu.ma@xxxxxxxxxxxxx> wrote:

So the problematic case is when RAPL=Y IOSF=M
Since real IOSF functions are available when
#if IS_ENABLED(CONFIG_IOSF_MBI)
There will be no dummy functions for RAPL to reference in this
case.
iosf_mbi_write/read will warn itself.
it does not compile.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/