Re: [PATCH 3/6] drm/imx: Build monolithic driver

From: Philipp Zabel
Date: Fri Sep 25 2015 - 09:09:24 EST


Am Freitag, den 25.09.2015, 14:17 +0200 schrieb Thierry Reding:
> I think you gain much less by splitting up than you realize. Compare
> this from before the series:
>
> $ du -ch drivers/gpu/drm/imx/*.ko
> 8.0K drivers/gpu/drm/imx/dw_hdmi-imx.ko

Oh right, I didn't realize that this is just the shim. The bulk of the
HDMI driver is in bridge/dw_hdmi.ko.

> 16K drivers/gpu/drm/imx/imxdrm.ko
> 16K drivers/gpu/drm/imx/imx-ipuv3-crtc.ko
> 12K drivers/gpu/drm/imx/imx-ldb.ko
> 12K drivers/gpu/drm/imx/imx-tve.ko
> 8.0K drivers/gpu/drm/imx/parallel-display.ko
> 72K total
[...]
> with this after the series:
>
> $ du -ch drivers/gpu/drm/imx/*.ko
> 44K drivers/gpu/drm/imx/imx-drm.ko
> 44K total
[...]
> There are other things to consider as well, such as the additional
> memory overhead caused by merely having multiple modules, or all of the
> exported functions that unnecessarily clutter up the symbol table, and
> which end up slowing down every symbol lookup.

Thanks, can't argue with those numbers.
I'll queue patches 3 and 4 for imx-drm.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/