Re: [PATCH 13/19] extcon: sm5502: fix handling regmap_irq_get_virq result

From: Chanwoo Choi
Date: Thu Sep 24 2015 - 19:40:40 EST


On 2015ë 09ì 24ì 23:00, Andrzej Hajda wrote:
> The function can return negative value.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> ---
> Hi,
>
> To avoid problems with too many mail recipients I have sent whole
> patchset only to LKML. Anyway patches have no dependencies.
>
> Regards
> Andrzej
> ---
> drivers/extcon/extcon-sm5502.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c
> index 92ae484..2945091 100644
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -586,7 +586,7 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c,
>
> for (i = 0; i < info->num_muic_irqs; i++) {
> struct muic_irq *muic_irq = &info->muic_irqs[i];
> - unsigned int virq = 0;
> + int virq = 0;
>
> virq = regmap_irq_get_virq(info->irq_data, muic_irq->irq);
> if (virq <= 0)
>

Applied it.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/