Re: [PATCH v2] usb: gadget: f_sourcesink: fix function params handling
From: Krzysztof Opasiak
Date: Thu Sep 24 2015 - 13:36:19 EST
On 09/24/2015 06:49 PM, Felipe Balbi wrote:
On Thu, Sep 24, 2015 at 05:23:09PM +0200, Robert Baldyga wrote:
Move function parameters to struct f_sourcesink to make them per instance
instead of having them as global variables. Since we can have multiple
instances of USB function we also want to have separate set of parameters
for each instance.
Cc: <stable@xxxxxxxxxxxxxxx> # 3.10+
Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
why do you think this is stable material ? Looks like it's not
fixing anything to me; just implementing a brand new requirement.
Please see my answer in loopback patch[1]. It's totally the same case.
Both those functions have the same bug.
Footnotes:
1 - http://marc.info/?l=linux-usb&m=144311466118170&w=2
--
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/