Re: [PATCH v2] netlink: Replace rhash_portid with bound

From: Tejun Heo
Date: Wed Sep 23 2015 - 23:41:59 EST


On Thu, Sep 24, 2015 at 11:31:17AM +0800, Herbert Xu wrote:
> No this isn't what happened. My error was trying to see if there
> is a way to do it without barriers. In the end there wasn't. This
> has nothing to do with using primitives.

Hmmm... yeah, you can say that, but it still was a failure to
recognize and apply the common pattern and what you're suggesting is
deviating for no good reason. It demands a lot of cognitive overhead
for something which should be routine and makes the code a lot more
fragile as a result. Things like this make barrier usages difficult
to understand and verify because it takes away a lot of ready-made
cognitive tools. So, let's please stick to the known pattern.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/