Re: [linux-sunxi] Re: [PATCH 5/5] ARM: sun5i: Add C.H.I.P DTS

From: Maxime Ripard
Date: Tue Sep 22 2015 - 10:04:30 EST


On Tue, Sep 22, 2015 at 03:01:58PM +0200, Hans de Goede wrote:
> >In short, this is not about "power supply" but VBUS detection. IIRC,
> >if no VBUS detection method is provided, the phy driver just waits a
> >period of time after an ID pin change and then considers VBUS invalid.
>
> Right, but that is a hack for boards with no / broken vbus detection
> (or vbus control), we really want to use vbus-det where available,
> so I agree that a TODO comment here would be good.

What's so special in our SoCs that makes that we can't just rely on
the ID pin ? (which seems to be working just fine here)

Other SoCs don't need to rely on such a hack as well.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: Digital signature