Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

From: David Miller
Date: Mon Sep 21 2015 - 19:12:41 EST


From: Robert Jarzmik <robert.jarzmik@xxxxxxx>
Date: Fri, 18 Sep 2015 18:36:56 +0200

> Which brings me to wonder which is the more correct :
> (a) replace to reproduce the same calculation
> Previously mtt was compared to a difference of 76ns steps (as 307ns / 4 =
> 76ns):
> while ((sched_clock() - si->last_clk) * 76 < mtt)
>
> (b) change the calculation assuming mtt is in microseconds :
> while ((sched_clock() - si->last_clk) * 1000 < mtt)
>
> I have no IRDA protocol knowledge so unless someone points me to the correct
> calculation I'll try my luck with (b).

"a" would be "safer" and less likely to break anything, although as
you say "b" might be more correct.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/