Re: Possible Bug in move_encrypted_block

From: Jaegeuk Kim
Date: Mon Sep 21 2015 - 14:51:23 EST


Hi,

On Sat, Sep 19, 2015 at 01:36:08PM -0400, nick wrote:
> Greetings Jaeguek and others.
> Below are the lines fora possible bug in move_encrypted_block:
> err = get_dnode_of_data(&dn, bidx, LOOKUP_NODE);
> if (err)
> goto out;
> Also calls of get_dnode_of_data need to hold the semaphone for the superblock
> this call is being done on to avoid concurrent access on data being received

IIUC, the f2fs_lock_op() is not neeeded here. Do you mean this?
To be honest, I can't catch your point.

Thanks,

> here from the superblock and file system on disk. In addition unless I get a
> reply to this I will not be sending in a bug fix for this.
> Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/