Re: [PATCH v2 1/2] input: Add Qualcomm PM8941 power key driver

From: Bjorn Andersson
Date: Mon Sep 21 2015 - 00:49:11 EST


On Tue 15 Sep 04:36 PDT 2015, Ivan T. Ivanov wrote:

>
> On Fri, 2015-01-23 at 16:19 -0800, Bjorn Andersson wrote:
> > From: Courtney Cavin cavin@xxxxxxxxxxxxxx>
> >
> > Signed-off-by: Courtney Cavin cavin@xxxxxxxxxxxxxx>
> > Signed-off-by: Bjorn Andersson andersson@xxxxxxxxxxxxxx>
> >
>
> <snip>
>
> >
> > +config INPUT_PM8941_PWRKEY
> > + tristate "Qualcomm PM8941 power key support"
> > + depends on MFD_SPMI_PMIC
> > + help
> > + Say Y here if you want support for the power key usually found
> > + on boards using a Qualcomm PM8941 compatible PMIC.
> > +
>
> Hi Bjorn, Courtney,
>
> Do you plan to extend this driver to support RESIN_N PMIC input?
>

It's way down on the todo-list, so not right now.

> It looks like the same downstream "qcom,qpnp-power-on" handle
> this functionality for recent PMIC versions.
>

Right, it seems to be functionality in the PON block.

> What will be the best way to add this new functionality, extend
> this driver, write new one...?
>

Perhaps the naming of the driver isn't the best in the end, but I think
it should be implemented by the same driver...

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/