Re: [PATCH v8 03/13] KVM: Define a new interface kvm_intr_is_single_vcpu()

From: Radim KrÄmÃÅ
Date: Fri Sep 18 2015 - 12:16:43 EST


2015-09-17 23:18+0000, Wu, Feng:
>> From: Paolo Bonzini [mailto:pbonzini@xxxxxxxxxx]
>> On 17/09/2015 17:58, Radim KrÄmÃÅ wrote:
>>> xAPIC address are only 8 bit long so they always get delivered to x2APIC
>>> cluster 0, where first 16 bits work like xAPIC flat logical mode.
>>
>> Ok, I was wondering whether this was the correct interpretation. Thanks!
>
> Paolo, I don't think Radim clarify your concern, right? Since mda is 8-bit, it
> is wrong with mda >> 16, this is your concern, right?

In case it was: mda is u32 so the bitshift is defined by C.
(xAPIC destinations in KVM's x2APIC mode are stored in lowest 8 bits of
mda, hence the cluster is always 0.)

Or am I still missing the point?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/