Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation

[Christian KÃnig]

On 16.09.2015 11:56, Andrzej Hajda wrote:
> Ping.
>
> Regards
> Andrzej
>
> On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> > The patch was generated using fixed coccinelle semantic patch
> > scripts/coccinelle/api/memdup.cocci [1].
> >
> > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
> >
> > Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>

Somehow missed that. Patch is Reviewed-by: Christian KÃnig 
<christian.koenig@xxxxxxx>.

Regards,
Christian.

> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> > index 8da6424..94bd992 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> > @@ -549,12 +549,10 @@ int amdgpu_bo_set_metadata (struct amdgpu_bo *bo, void *metadata,
> >   	if (metadata == NULL)
> >   		return -EINVAL;
> >   
> > -	buffer = kzalloc(metadata_size, GFP_KERNEL);
> > +	buffer = kmemdup(metadata, metadata_size, GFP_KERNEL);
> >   	if (buffer == NULL)
> >   		return -ENOMEM;
> >   
> > -	memcpy(buffer, metadata, metadata_size);
> > -
> >   	kfree(bo->metadata);
> >   	bo->metadata_flags = flags;
> >   	bo->metadata = buffer;
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/