Re: [PATCH 21/31] fs/dlm: use kmemdup rather than duplicating its implementation

From: Andrzej Hajda
Date: Wed Sep 16 2015 - 06:04:12 EST


Ping.

Regards
Andrzej

On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> ---
> fs/dlm/lowcomms.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
> index 754fd6c..b31b32a 100644
> --- a/fs/dlm/lowcomms.c
> +++ b/fs/dlm/lowcomms.c
> @@ -1317,10 +1317,9 @@ static void init_local(void)
> if (dlm_our_addr(&sas, i))
> break;
>
> - addr = kmalloc(sizeof(*addr), GFP_NOFS);
> + addr = kmemdup(&sas, sizeof(*addr), GFP_NOFS);
> if (!addr)
> break;
> - memcpy(addr, &sas, sizeof(*addr));
> dlm_local_addr[dlm_local_count++] = addr;
> }
> }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/