Re: [PATCH] irqdomain: remove the confused log

From: Thomas Gleixner
Date: Tue Aug 25 2015 - 15:34:35 EST


On Tue, 25 Aug 2015, Huang Shijie wrote:

> When the dynamic debug is enabled for irq domain, the kernel will print out:
> ------------------------------------------------------
> irqdomain:__irq_domain_add: irq: Added domain (null)
> ------------------------------------------------------
>
> It does not print out the irq domain's name, since the @domain->name is NULL.
> Keep the log here just makes people nervous.

Well, it might be NULL in your case, but there are enough cases where
its not NULL and the output valuable.


Aside of that I don't understand what's making one nervous
here. People who enable that debug stuff should know that this can be
NULL and just deal with it. If they get nervous about it they probably
should not try to debug that code in the first place.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/