Re: [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug

From: Paul Gortmaker
Date: Fri Aug 21 2015 - 15:20:26 EST


On Fri, Aug 14, 2015 at 9:12 AM, Leonidas S Barbosa
<leosilva@xxxxxxxxxxxxxxxxxx> wrote:
> AES-CTR is using a counter 8bytes-8bytes what miss match with
> kernel specs.
>
> In the previous code a vadduwm was done to increment counter.
> Replacing this for a vadduqm now considering both cases counter
> 8-8 bytes and full 16bytes.

Seems this breaks ppc allmodconfig:

drivers/crypto/vmx/aesp8-ppc.S:1545: Error: Unrecognized opcode: `vadduqm'

1d4aa0b4c1816e8ca92a6aadb0d8f6b43c56c0d0 is the first bad commit
commit 1d4aa0b4c1816e8ca92a6aadb0d8f6b43c56c0d0
Author: Leonidas Da Silva Barbosa <leosilva@xxxxxxxxxxxxxxxxxx>
Date: Fri Aug 14 10:12:22 2015 -0300

crypto: vmx - Fixing AES-CTR counter bug


http://kisskb.ellerman.id.au/kisskb/buildresult/12490159/


Paul.
--

>
> Signed-off-by: Leonidas S Barbosa <leosilva@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/crypto/vmx/aes_ctr.c | 8 +++++++-
> drivers/crypto/vmx/aesp8-ppc.pl | 34 +++++++++++++++++-----------------
> 2 files changed, 24 insertions(+), 18 deletions(-)
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/