Re: [PATCH] x86, bitops, variable_test_bit should return 1 not -1 on a match

From: Prarit Bhargava
Date: Fri Aug 21 2015 - 07:53:23 EST




On 08/21/2015 04:08 AM, H. Peter Anvin wrote:
> Wrong fix, though. Instead we should change it to use the set instruction, which would also make it easier to use the CC_SET/CC_OUT proposed macros to use assembly out in the future.
>
> The downside with set is that it only sets a single byte, the upside is that it always outputs 0 or 1, and apparently if the output variable is your bool gcc can use that for optimization.
>

hpa -- can you send a pointer to that discussion?

Thanks,

P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/