RE: [PATCH v4] mfd: add Intel Broxton Whiskey Cove PMIC driver

[Zha, Qipeng]

>  intel-soc-pmic-objs		:= intel_soc_pmic_core.o intel_soc_pmic_crc.o
> +intel-soc-pmic-$(CONFIG_INTEL_PMC_IPC)	+= intel_soc_pmic_bxtwc.o

> You want to build this for all Intel products?
As intel_soc_pmic_crc driver, this is depend on the option of CONFIG_INTEL_SOC_PMIC,
And it's depend on CONFIG_INTEL_PMC_IPC since hardware dependency.

> +
> +/* sysfs interfaces to r/w PMIC registers, required by initial script 
> +*/

> You really want to be able to do that from userspace?
There is real requirement for this.