Re: [PATCH] net/fsl: simplify Kconfig dependency list for fsl networking

[Geert Uytterhoeven]

On Fri, Aug 14, 2015 at 12:01 AM, Stuart Yoder
<stuart.yoder@xxxxxxxxxxxxx> wrote:
> make the list of Kconfig dependencies for Freescale
> networking more general. Simplify to supported
> architectures: ARM, ARM64, PPC, M68K
>
> Signed-off-by: Stuart Yoder <stuart.yoder@xxxxxxxxxxxxx>
> ---
>  drivers/net/ethernet/freescale/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index ff76d4e..70782d7 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -5,9 +5,7 @@
>  config NET_VENDOR_FREESCALE
>         bool "Freescale devices"
>         default y
> -       depends on FSL_SOC || QUICC_ENGINE || CPM1 || CPM2 || PPC_MPC512x || \
> -                  M523x || M527x || M5272 || M528x || M520x || M532x || \
> -                  ARCH_MXC || ARCH_MXS || (PPC_MPC52xx && PPC_BESTCOMM)
> +       depends on M68K || PPC || ARM || ARM64
>         ---help---
>           If you have a network (Ethernet) card belonging to this class, say Y.

This breaks m68k/allmodconfig:

drivers/net/ethernet/freescale/gianfar.c: In function âgfar_parse_groupâ:
drivers/net/ethernet/freescale/gianfar.c:684: error: âNO_IRQâ
undeclared (first use in this function)
drivers/net/ethernet/freescale/gianfar.c:684: error: (Each undeclared
identifier is reported only once
drivers/net/ethernet/freescale/gianfar.c:684: error: for each function
it appears in.)

P.S. Hint: Would have been caught earlier if the NET_VENDOR_* symbol
     had "|| COMPILE_TEST" among its dependencies.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/