Re: [4.2-rc1][PATCH] gpio: omap: add missed spin_unlock_irqrestore in omap_gpio_irq_type

[Linus Walleij]

On Fri, Aug 7, 2015 at 9:34 AM, Grygorii Strashko
<grygorii.strashko@xxxxxx> wrote:
> Hi Tony,
> On 08/07/2015 06:36 AM, Tony Lindgren wrote:
>>
>> * Linus Walleij <linus.walleij@xxxxxxxxxx> [150716 01:38]:
>>>
>>> On Wed, Jun 24, 2015 at 4:54 PM, Grygorii Strashko
>>> <grygorii.strashko@xxxxxx> wrote:
>>>
>>>> From: Grygorii Strashko <grygorii.strashko@xxxxxxxxxx>
>>>>
>>>> Add missed spin_unlock_irqrestore in omap_gpio_irq_type when
>>>> omap_set_gpio_triggering() is failed.
>>>>
>>>> It fixes static checker warning:
>>>>
>>>>          drivers/gpio/gpio-omap.c:523 omap_gpio_irq_type()
>>>>          warn: inconsistent returns 'spin_lock:&bank->lock'.
>>>>
>>>> This fixes commit:
>>>> 1562e4618ded ('gpio: omap: fix error handling in omap_gpio_irq_type')
>>>>
>>>> Reported-by: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxxxxxx>
>>>
>>>
>>> Patch applied for fixes.
>>
>>
>> Linus, looks like we now have a new build warning in Linux next
>> with the fixes and raw_spinlock_t change, so a merge or a commit
>> is needed. If you prefer a patch, here's one below.
>
>
> Yes. It seems merge/rebase issue between fixes & next:
> - this patch went through fixes and RAW spinlock conversation
> patch through -next, and without merge conflicts.
>
> and patch has been posted already by Axel Lin:
> http://www.spinics.net/lists/linux-omap/msg121031.html

I merged v4.2-rc4 into my devel branch and applied Axel's
patch to fix this mess. Check that it looks OK now...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/