Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

[Sudeep Holla]

On 13/08/15 10:51, Grygorii Strashko wrote:
> On 08/13/2015 11:54 AM, Sudeep Holla wrote:
> > On 12/08/15 18:45, Grygorii Strashko wrote:

[...]

> > > diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> > > index 6de638b..bdb1b9d 100644
> > > --- a/kernel/irq/chip.c
> > > +++ b/kernel/irq/chip.c
> > > @@ -1024,6 +1024,10 @@ int irq_chip_set_vcpu_affinity_parent(struct
> > > irq_data *data, void *vcpu_info)
> > >    int irq_chip_set_wake_parent(struct irq_data *data, unsigned int on)
> > >    {
> > >        data = data->parent_data;
> > > +
> > > +    if (irq_data_get_irq_chip(data)->flags & IRQCHIP_SKIP_SET_WAKE)
> > > +        return 0;
> > > +
> >
> > [Nit] I think the irq core can access data->chip directly. Either way,
> > it's better to be consistent, the statement following doesn't use helper
> > function.
>
> thanks. I'll change it to:
> 	if (data->chip->flags & IRQCHIP_SKIP_SET_WAKE)
> 		return 0;
>
> > Otherwise looks good to me.
>
> Does it means that I can add your Reviewed-by: with above change?

Yes you can.

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/