Re: [GIT PULL] MODSIGN: Use PKCS#7 for module signatures [ver #7a]

From: James Morris
Date: Wed Aug 12 2015 - 06:30:49 EST


On Wed, 12 Aug 2015, David Woodhouse wrote:

> On Wed, 2015-08-12 at 20:08 +1000, James Morris wrote:
> > make-3.81-20.el6.x86_64
> >
> > The machine is not accessible, sorry.
>
> No matter. I have a CentOS 6 VM in which I can attempt to reproduce.
>
> > Where is MODULE_SIG_KEY_FILENAME assigned?
>
> At about line 243:
>
> $(eval $(call config_filename,MODULE_SIG_KEY))
>
> Or, more to the point, somewhere in here... you may now understand why
> I made a new jug of coffee. I had torture-tested this with fairly much
> every pathology I could think of. And you've managed to break it with
> the *default* case. Congratulations. You just made me cry.

You made me read Make documentation -- I think we're even.

> #
> define config_filename =

This may be relevant:

http://stackoverflow.com/questions/13260396/gnu-make-3-81-eval-function-not-working


--
James Morris
<jmorris@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/