[PATCH] kmod: correct documentation of return status of request_module

From: NeilBrown
Date: Wed Aug 12 2015 - 00:17:05 EST




if request_module() successfully runs modprobe, but modprobe
exits with a non-zero status, then the return value from
request_module() will be that (positive) error status.
So the return from request_module can be:
negative errno
zero for success
positive exit code.

Signed-off-by: NeilBrown <neilb@xxxxxxxx>
Cc: Goldwyn Rodrigues <rgoldwyn@xxxxxxx>

diff --git a/kernel/kmod.c b/kernel/kmod.c
index 2777f40a9c7b..1734ba61ff23 100644
--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -114,10 +114,11 @@ out:
* @...: arguments as specified in the format string
*
* Load a module using the user mode module loader. The function returns
- * zero on success or a negative errno code on failure. Note that a
- * successful module load does not mean the module did not then unload
- * and exit on an error of its own. Callers must check that the service
- * they requested is now available not blindly invoke it.
+ * zero on success or a negative errno code or positive exit code from
+ * "modprobe" on failure. Note that a successful module load does not mean
+ * the module did not then unload and exit on an error of its own. Callers
+ * must check that the service they requested is now available not blindly
+ * invoke it.
*
* If module auto-loading support is disabled then this function
* becomes a no-operation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/