Re: [PATCH v2 3/5] mm/hwpoison: introduce put_hwpoison_page to put refcount for memory error handling

[Wanpeng Li]

On 8/12/15 7:24 AM, Andrew Morton wrote:
> On Mon, 10 Aug 2015 19:28:21 +0800 Wanpeng Li <wanpeng.li@xxxxxxxxxxx> wrote:
>
> > Introduce put_hwpoison_page to put refcount for memory
> > error handling.
> >
> > ...
> >
> > --- a/mm/memory-failure.c
> > +++ b/mm/memory-failure.c
> > @@ -922,6 +922,27 @@ int get_hwpoison_page(struct page *page)
> >   }
> >   EXPORT_SYMBOL_GPL(get_hwpoison_page);
> >   
> > +/**
> > + * put_hwpoison_page() - Put refcount for memory error handling:
> > + * @page:	raw error page (hit by memory error)
> > + */
> > +void put_hwpoison_page(struct page *page)
> > +{
> > +	struct page *head = compound_head(page);
> > +
> > +	if (PageHuge(head)) {
> > +		put_page(head);
> > +		return;
> > +	}
> > +
> > +	if (PageTransHuge(head))
> > +		if (page != head)
> > +			put_page(head);
> > +
> > +	put_page(page);
> > +}
> > +EXPORT_SYMBOL_GPL(put_hwpoison_page);
> I don't believe the export is needed?

ERROR: "put_hwpoison_page" [mm/hwpoison-inject.ko] undefined!
So I'm afraid it should be needed.

Regards,
Wanpeng Li

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/