RE: [PATCH V2 1/1] perf/x86: Add Intel power cstate PMUs support

From: Liang, Kan
Date: Thu Aug 06 2015 - 15:26:09 EST



>
> On Thu, Aug 6, 2015 at 11:52 AM, Liang, Kan <kan.liang@xxxxxxxxx> wrote:
> >
> >
> >> >> +static cpumask_t power_cstate_core_cpu_mask;
> >> >
> >> > That one typically does not need a cpumask.
> >> >
> >> You need to pick one CPU out of the multi-core. But it is for client
> >> parts thus there is only one socket. At least this is my understanding.
> >>
> >
> > CORE_C*_RESIDENCY are available for physical processor core.
> > So logical processor in same physical processor core share the same
> > counter.
> > I think we need the cpumask to identify the default logical processor
> > which do counting.
> >
> Did you restrict these events to system-wide mode only?
>

Yes