Re: [PATCH v8 1/3] sysfs: added sysfs_link_entry_to_kobj()

From: Greg Kroah-Hartman
Date: Wed Aug 05 2015 - 16:11:29 EST


On Fri, Jul 03, 2015 at 05:27:18PM +0300, Jarkko Sakkinen wrote:
> Added a new function sysfs_link_group_to_kobj() that adds a symlink
> from attribute or group to a kobject. Exported kernfs_remove_by_name_ns
> in order to provide a way to remove such symlinks.

This text doesn't match the function name you exported :(

>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> ---
> fs/sysfs/group.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> include/linux/sysfs.h | 10 ++++++++++
> 2 files changed, 54 insertions(+)
>
> diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c
> index b400c04..0fb4b6e 100644
> --- a/fs/sysfs/group.c
> +++ b/fs/sysfs/group.c
> @@ -352,3 +352,47 @@ void sysfs_remove_link_from_group(struct kobject *kobj, const char *group_name,
> }
> }
> EXPORT_SYMBOL_GPL(sysfs_remove_link_from_group);
> +
> +/**
> + * __compat_sysfs_link_entry_to_kobj - add a symlink to a kobject pointing

Why __compat?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/