Re: [PATCH 1/3] x86/entry/64: Refactor IRQ stacks and make then NMI-safe

From: Ingo Molnar
Date: Wed Aug 05 2015 - 05:00:13 EST



* Andy Lutomirski <luto@xxxxxxxxxx> wrote:

> --- a/arch/x86/kernel/process_64.c
> +++ b/arch/x86/kernel/process_64.c
> @@ -280,6 +280,10 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p)
> unsigned fsindex, gsindex;
> fpu_switch_t fpu_switch;
>
> +#ifdef CONFIG_DEBUG_ENTRY
> + WARN_ON(this_cpu_read(irq_count));
> +#endif

Please introduce a less noisy (to the eyes) version of this, something like:

WARN_ON_DEBUG_ENTRY(this_cpu_read(irq_count));

or so, similar to WARN_ON_FPU().

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/