Re: [PATCH V2] iio: declare struct to fix warning

From: Lars-Peter Clausen
Date: Tue Aug 04 2015 - 03:54:25 EST


On 08/04/2015 09:52 AM, Pengyu Ma wrote:
> If this patch is fine, could somebody help me to merge into upstream kernel?

It will be merged, don't worry. But things typically take a bit longer than
just a single day.

>
> Thanks,
> Pengyu
>
> On 08/03/2015 10:39 AM, Pengyu Ma wrote:
>> When compile iio related driver the following warning shown:
>>
>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>> declared inside parameter list
>> int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>
>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>> declared inside parameter list
>> struct iio_dev *indio_dev);
>>
>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>> forward declaration for these structs to fix warning.
>>
>> Signed-off-by: Pengyu Ma <pengyu.ma@xxxxxxxxxxxxx>
>> ---
>> include/linux/iio/trigger.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>> index fa76c79..974cf73 100644
>> --- a/include/linux/iio/trigger.h
>> +++ b/include/linux/iio/trigger.h
>> @@ -18,6 +18,10 @@ struct iio_subirq {
>> bool enabled;
>> };
>> +/* forward declaration */
>> +struct iio_dev;
>> +struct iio_trigger;
>> +
>> /**
>> * struct iio_trigger_ops - operations structure for an iio_trigger.
>> * @owner: used to monitor usage count of the trigger.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/