Re: [PATCH v5] powerpc/rcpm: add RCPM driver

[Scott Wood]

On Mon, 2015-08-03 at 19:14 +0800, Chenhui Zhao wrote:
> On Sat, Aug 1, 2015 at 8:45 AM, Scott Wood <scottwood@xxxxxxxxxxxxx> 
> wrote:
> > On Fri, 2015-06-26 at 15:44 +0800,  Yuantian.Tang@xxxxxxxxxxxxxxxxxx:
> > >  +static void rcpm_v1_set_ip_power(bool enable, u32 *mask)
> > >  +{
> > >  +     if (enable)
> > >  +             setbits32(&rcpm_v1_regs->ippdexpcr, *mask);
> > >  +     else
> > >  +             clrbits32(&rcpm_v1_regs->ippdexpcr, *mask);
> > >  +}
> > >  +
> > >  +static void rcpm_v2_set_ip_power(bool enable, u32 *mask)
> > >  +{
> > >  +     if (enable)
> > >  +             setbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
> > >  +     else
> > >  +             clrbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
> > >  +}
> > 
> > Why do these take "u32 *mask" instead of "u32 mask"?
> > 
> > -Scott
> 
> I think it can be used in the case where there are several mask values.

When would that be?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/