RE: [PATCH v2 2/2] powerpc/mpc85xx: Add FSL QorIQ DPAA FMan support to the SoC device tree(s)

[Liberman Igal]

Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, July 30, 2015 11:12 PM
> To: Liberman Igal-B31950
> Cc: devicetree@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx; Bucur
> Madalin-Cristian-B32716; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/2] powerpc/mpc85xx: Add FSL QorIQ DPAA FMan
> support to the SoC device tree(s)
> 
> On Thu, 2015-07-30 at 07:33 +0300, Igal.Liberman wrote:
> > @@ -307,4 +307,117 @@
> >               reg = <0xe0000 0x1000>;
> >               fsl,has-rstcr;
> >       };
> > +
> > +      fman@100000{
> > +             #address-cells = <1>;
> > +             #size-cells = <1>;
> > +             cell-index = <0>;
> > +             ranges = <0 0x100000 0x100000>;
> > +             compatible = "fsl,fman";
> > +             reg = <0x100000 0x100000>;
> > +             interrupts = <24 2 0 0>, <16 2 1 30>;
> > +             clock-frequency = <0>;
> > +             fsl,qman-channel-range = <0x40 0x7>;
> 
> fman is supposed to have clocks/clock-names, not clock-frequency.
> 

The new clock binding doesn't support P1023 yet. 
I'll drop P1023 from this submission, it's not supported currently by the driver, we'll re-add it later. 

> -Scott