Re: [PATCH v5 3/8] clk: add support for clocks provided by SCP(System Control Processor)

[Sudeep Holla]

On 29/07/15 18:37, Stephen Boyd wrote:
> On 07/23/2015 04:10 AM, Sudeep Holla wrote:
> > On some ARM based systems, a separate Cortex-M based System Control
> > Processor(SCP) provides the overall power, clock, reset and system
> > control. System Control and Power Interface(SCPI) Message Protocol
> > is defined for the communication between the Application Cores(AP)
> > and the SCP.
> >
> > This patch adds support for the clocks provided by SCP using SCPI
> > protocol.
> >
> > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> > Cc: Mike Turquette <mturquette@xxxxxxxxxxxx>
> > Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> > Cc: Liviu Dudau <Liviu.Dudau@xxxxxxx>
> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> > Cc: Jon Medhurst (Tixy) <tixy@xxxxxxxxxx>
> > Cc: linux-clk@xxxxxxxxxxxxxxx
>
> Looks good to me, modulo one comment.
>
> Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

Thanks, I assume you are fine if this gets merged via arm-soc

> > +
> > +static const struct of_device_id scpi_clocks_ids[] = {
> > +	{ .compatible = "arm,scpi-clocks", },
> > +	{}
> > +};
>
> Did you want a MODULE_DEVICE_TABLE() here?

Yes, I do and it's added now.

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/