Re: [PATCH] net/phy: micrel: Reenable interrupts during resume

From: David Miller
Date: Thu Jul 30 2015 - 02:55:38 EST


From: Nathan Sullivan <nathan.sullivan@xxxxxx>
Date: Wed, 29 Jul 2015 10:21:14 -0500

> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 499185e..7a93af6 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -447,6 +447,22 @@ static int ksz9031_center_flp_timing(struct phy_device *phydev)
> return genphy_restart_aneg(phydev);
> }
>
> +static int ksz9031_resume(struct phy_device *phydev)
> +{
> + int result;
> +
> + result = genphy_resume(phydev);
> +
> + if (result)
> + return result;
> +
> + /* This phy will reset interrupt enables when leaving power down */
> + if (PHY_INTERRUPT_ENABLED & phydev->interrupts)
> + result = kszphy_set_interrupt(phydev);
> +

This doesn't compile.

drivers/net/phy/micrel.c: In function ʽksz9031_resumeʼ:
drivers/net/phy/micrel.c:461:3: error: implicit declaration of function ʽkszphy_set_interruptʼ [-Werror=implicit-function-declaration]
result = kszphy_set_interrupt(phydev);
^
cc1: some warnings being treated as errors
scripts/Makefile.build:264: recipe for target 'drivers/net/phy/micrel.o' failed