Re: [PATCH 1/4] opp: add dev_pm_opp_is_turbo() helper

[Viresh Kumar]

On 28-07-15, 16:27, Pavel Machek wrote:
> Typo.
> 
> And this is not exactly most helpful comment. opp is turbo... returns
> if opp was turbo. Explanation what "turbo" means in this context would
> be nice. I'm pretty sure it is not about air compression :-).

Does this make it any better:

diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index e039cf024a6c..da8ec7f824d5 100644
--- a/drivers/base/power/opp.c
+++ b/drivers/base/power/opp.c
@@ -281,9 +281,13 @@ unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp)
 EXPORT_SYMBOL_GPL(dev_pm_opp_get_freq);
 
 /**
- * dev_pm_opp_is_turbo() - Returns true if opp was trubo OPP
+ * dev_pm_opp_is_turbo() - Returns if opp is turbo OPP or not
  * @opp: opp for which turbo mode is being verified
  *
+ * Turbo OPPs are not for normal use, and can be enabled (under certain
+ * conditions) for short duration of times to finish high throughput work
+ * quickly. Running on them for longer times may overheat the chip.
+ *
  * Return: true if opp is turbo opp, else false.
  *
  * Locking: This function must be called under rcu_read_lock(). opp is a rcu


-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/