Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

[Julia Lawall]

> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 83d4bca..1ded691 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -204,13 +204,13 @@ static inline char *translate_scan(struct _adapter *padapter,
>  	/* Add the protocol name */
>  	iwe.cmd = SIOCGIWNAME;
>  	if ((r8712_is_cckratesonly_included(pnetwork->network.
> -	     SupportedRates)) == true) {
> +	     rates)) == true) {
>  		if (ht_cap == true)
>  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
>  		else
>  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
>  	} else if ((r8712_is_cckrates_included(pnetwork->network.
> -		    SupportedRates)) == true) {
> +		    rates)) == true) {
>  		if (ht_cap == true)
>  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
>  		else

The placement of the line breaks here is partucularly unpleasant.  Perhaps
that could be adjusted now that the field name is shorter.  Theer may be
some other cases in the patch where the line breaks could be adjusted to
improve readability.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/