Re: Is devm_* broken ?

From: Tejun Heo
Date: Tue Jul 28 2015 - 11:22:33 EST


Hello, Laurent.

On Tue, Jul 28, 2015 at 05:16:16PM +0300, Laurent Pinchart wrote:
> Using devm_kzalloc() in such a way has value though, and reverting drivers to
> the pre-devm memory allocation code would make error handling and cleanup code
> paths more complex again. Should we introduce a managed allocator for that
> purpose that would have a lifespan explicitly handled by drivers ?

I don't know. Sure, we can have memory allocations which are tied to
open file; however, the distinction between that and regular devm
resources, which can't linger on no matter what, would be subtle and
confusing. IMHO, a better approach would be implmenting generic
revoke feature and sever open files on driver detach so that
everything can be shutdown then.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/