Re: [RFC PATCH 03/16] x86/boot: Public getting random boot function

[Pavel Machek]

Hi!

>  int cmdline_find_option_bool(const char *option);
>  #endif
>  
> +#if CONFIG_RANDOMIZE_BASE

Not ifdef?

> +extern u16 i8254(void);

That's rather poor name for global function...

>  #if CONFIG_RANDOMIZE_BASE

Ok, maybe not, but I'm confused.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/