Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data

From: Guenter Roeck
Date: Mon Jul 27 2015 - 10:24:21 EST


On 07/27/2015 07:19 AM, Matt Fleming wrote:
On Mon, 27 Jul, at 06:49:08AM, Guenter Roeck wrote:

I don't see the platform data freed anywhere, neither in the error path nor
in the cleanup path of this driver. Can you use devm_kzalloc() ?
Otherwise I think you'll need a cleanup path.

Oops, good catch. Yes, devm_kzalloc() can be used here, thanks!

Or maybe just use a static data structure, like in the i2c driver.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/