Re: [PATCH 3/4] power: Add Qualcomm SMBB driver

[Sebastian Reichel]

Hi,

On Sat, Jul 25, 2015 at 06:04:14PM -0700, Bjorn Andersson wrote:
> On Sat 25 Jul 08:42 PDT 2015, Sebastian Reichel wrote:
> >  * battery-charge-control-limit
> > 
> > It's unclear, what this property is used for. Is the limit only
> > for "normal" charging or also for fast charging?
> > 
> 
> This is described as the current limit during fast charging. However,
> "fast charging" is the normal state.
> 
> I think the most consistent (regards documentation and other properties)
> would be:
> 
>  qcom,fast-charge-current-limit

So what's the difference to "fast-charge-safe-current"?

> >  * minimum-input-voltage
> > 
> > Add a vendor prefix to this property.
> > 
> 
> Shouldn't they all have a vendor prefix?

Some of the properties are quite generic and used on multiple
chips, so we may create a power_supply/battery-fuel-gauge.txt
and power_supply/battery-charger.txt with generic bindings.

I'm fine with just adding vendor prefixed properties for all
instances, though.

> Thanks for the review, I'll update the patches accordingly and
> will send out v2 (and make sure you get the dt binding document
> as well).

OK, thanks.

-- Sebastian

Attachment: signature.asc
Description: Digital signature