Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

From: Heiko Carstens
Date: Mon Jul 27 2015 - 06:51:46 EST


On Mon, Jul 27, 2015 at 12:45:10PM +0200, Peter Zijlstra wrote:
> --- a/arch/s390/include/asm/jump_label.h
> +++ b/arch/s390/include/asm/jump_label.h
> +static __always_inline bool arch_static_branch_jump(struct static_key *key, bool branch)
> +{
> + asm_volatile_goto("0: brcl 15, %l[l_yes]\n"
> + ".pushsection __jump_table, \"aw\"\n"
> + ".balign 8\n"
> + ".quad 0b, %l[label], %0\n"
> + ".popsection\n"
> + : : "X" (&((char *)key)[branch]) : : label);

The above should have been

asm_volatile_goto("0: brcl 15,%l[label]\n"

(label instead of l_yes). Just recognized this, sorry..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/