Re: [PATCH 3/4] cp210x: Store part number

From: Oliver Neukum
Date: Mon Jul 27 2015 - 05:29:27 EST


On Mon, 2015-07-27 at 08:50 +0200, Petr Tesarik wrote:
> I don't understand. While you're right that I copied this part from
> Sillicon Labs' driver without much thinking, and &spriv->bPartNumber
> can be used directly, I can't see any DMA on stack. FWIW
> cp210x_control_msg always allocates a buffer using kcalloc:
>
> buf = kcalloc(length, sizeof(__le32), GFP_KERNEL);
> /* ... */
> result = usb_control_msg(serial->dev,
> usb_rcvctrlpipe(serial->dev, 0),
> request, requesttype, value,
> spriv->bInterfaceNumber, buf, size,
> timeout);
>
> Is that what you mean?

Yes, sorry, that part wasn't so clear from the previous patch.

Sorry
Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/