Re: [PATCH 3/5] staging: rtl8712: remove duplicate struct

From: Greg Kroah-Hartman
Date: Fri Jul 24 2015 - 16:01:10 EST


On Thu, Jul 23, 2015 at 09:57:50PM -0700, Joshua Clayton wrote:
> struct ndis_wlan_bssid_ex is a dopelganger of
> struct wlan_bssid_ex, and is used about a third as often
>
> Switch all instances to wlan_bssid_ex
>
> This also gets rid of a use of typedef NDIS_802_11_RATES_EX
>
> Signed-off-by: Joshua Clayton <stillcompiling@xxxxxxxxx>
> ---
> drivers/staging/rtl8712/rtl871x_cmd.c | 17 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.h | 4 +--
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 10 ++++----
> drivers/staging/rtl8712/rtl871x_mlme.c | 35
> +++++++++++++--------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++---
> drivers/staging/rtl8712/wlan_bssdef.h | 23 ++----------------
> 8 files changed, 38 insertions(+), 61 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c
> b/drivers/staging/rtl8712/rtl871x_cmd.c
> index f07050d..ef71829 100644
> --- a/drivers/staging/rtl8712/rtl871x_cmd.c
> +++ b/drivers/staging/rtl8712/rtl871x_cmd.c
> @@ -456,9 +456,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
> INIT_LIST_HEAD(&pcmd->list);
> pcmd->cmdcode = _CreateBss_CMD_;
> pcmd->parmbuf = (unsigned char *)pdev_network;
> - pcmd->cmdsz = r8712_get_ndis_wlan_bssid_ex_sz((
> - struct ndis_wlan_bssid_ex *)
> - pdev_network);
> + pcmd->cmdsz = r8712_get_wlan_bssid_ex_sz(pdev_network);
> pcmd->rsp = NULL;
> pcmd->rspsz = 0;
> /* notes: translate IELength & Length after assign to cmdsz; */
> @@ -471,7 +469,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
>
> u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network
> *pnetwork)

Patch is line-wrapped and can not be applied :(

Can you redo this whole series and resend properly? Your 0/5 email
needs a subject as well...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/