Re: [PATCH] of/irq: introduce of_has_named_irqs helper

[Rob Herring]

On Fri, Jul 24, 2015 at 1:26 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> Sometimes drivers might wish to transition from index-based to named
> interrupt descriptions. To aid in decision-making when parsing device
> tree data let's provide a helper that will indicate the scheme that is
> being used.

Generally, IRQs are retrieved by platform_get_irq or
platform_get_irq_byname. Drivers should not call the of_irq_*
functions directly in most cases.

>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
>
> The intent is to it like this:
>
>         if (of_has_named_irqs(np) {
>                 /* Wake IRQ is optional */
>                 dev->wakeirq = of_irq_get_byname(np, "wakeup");
>                 if (dev->wakeirq < 0 && dev->wakeirq != -ENODATA)
>                         return dev->wakeirq;
>         }

of_irq_get_byname will already return an error if the property is not
present. Use that.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/