Re: [PATCH 2/2] gpiolib: assign chip owner to dev->driver->owner if not set

From: Alexandre Courbot
Date: Tue Jun 30 2015 - 09:41:56 EST


On Fri, Jun 26, 2015 at 2:30 AM, Grygorii Strashko
<grygorii.strashko@xxxxxx> wrote:
> Assign GPIO chip owner field to chip->dev->driver->owner if it was not
> configured by GPIO driver.

Sounds good, setting this field manually seems to make less and less
sense anyway as most drivers follow the device model.

>
> Cc: Johan Hovold <johan@xxxxxxxxxx>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
> ---
> Hi,
>
> There is also one positive additional side effect:
> lines like below can be removed from a lot of GPIO
> drivers
> rdc321x_gpio_dev->chip.owner = THIS_MODULE;

A good idea for a follow-up patch! ;)

Acked-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/