Re: [PATCH] staging: gdm72xx: Split Kconfig descriptions into more lines

From: Luis de Bethencourt
Date: Fri Jun 26 2015 - 07:23:46 EST


On Thu, Jun 25, 2015 at 03:36:46PM -0700, Daniel Grimshaw wrote:
> I am a high school student trying to become familiar with linux kernel
> development. This is my first patch.
>
> checkpatch.pl throws a warning that config WIMAX_GDM72XX_QOS, config
> WIMAX_GDM72XX_K_MODE, and config WIMAX_GDM72XX_USB do not have enough
> of a description. By splitting the current description into multiple
> lines, the warning is removed.
>
> The module still worked with these changes when tested.
>
> Signed-off-by: Daniel Grimshaw <grimshaw@xxxxxxxxxxxxxxxxxx>
>

Hello Daniel,

Nice to see people submitting their first patch. Welcome :)

Besides what Dan Carpenter said, I wanted to add a comment about how to send
patches. Normally maintainers don't accept patches as attachments. You want to
send the patch inline.

I recommend these two resources to learn how:
http://kernelnewbies.org/FirstKernelPatch
Greg's talk "Write and Submit your first Linux kernel Patch"
- https://www.youtube.com/watch?v=LLBrBBImJt4

There is a bit of a learning curve. It is normal to not get it right the first
time. Feel free to email me directly with any further questions about this.

Happy hacking,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/