Re: [PATCH 7/9] arm: twr-k70f120m: IOMUX driver for Kinetis SoC

[Paul Osmialowski]

Hi Paul,

Thanks for your comments. I'll make it tristate.

On Wed, 24 Jun 2015, Paul Bolle wrote:

> On Tue, 2015-06-23 at 23:19 +0200, Paul Osmialowski wrote:
> > --- a/drivers/pinctrl/freescale/Kconfig
> > +++ b/drivers/pinctrl/freescale/Kconfig
>
> > +config PINCTRL_KINETIS
> > +	bool "Kinetis pinctrl driver"
> > +	depends on OF
> > +	depends on SOC_K70
> > +	select PINMUX
> > +	help
> > +	  Say Y here to enable the Kinetis pinctrl driver
>
> > --- a/drivers/pinctrl/freescale/Makefile
> > +++ b/drivers/pinctrl/freescale/Makefile
>
> > +obj-$(CONFIG_PINCTRL_KINETIS)	+= pinctrl-kinetis.o
>
> > --- /dev/null
> > +++ b/drivers/pinctrl/freescale/pinctrl-kinetis.c
>
> > +#include <linux/module.h>
>
> > +static struct pinctrl_desc kinetis_pinctrl_desc = {
> > +	[...]
> > +	.owner = THIS_MODULE,
> > +};
>
> > +static void __exit kinetis_pinctrl_exit(void)
> > +{
> > +	platform_driver_unregister(&kinetis_pinctrl_driver);
> > +}
> > +module_exit(kinetis_pinctrl_exit);
> > +
> > +MODULE_DESCRIPTION("Freescale Kinetis pinctrl driver");
> > +MODULE_LICENSE("GPL v2");
>
> pinctrl-kinetis.o can only be built-in, right? But the code uses a few
> module specific constructs. Did you mean to make PINCTRL_KINETIS
> tristate instead?
>
> Thanks,
>
>
> Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/