Re: [PATCH 08/17] ARM: dts: dra7: Add dt node for the sycon pcie

From: Tony Lindgren
Date: Wed Jun 24 2015 - 08:50:12 EST


* Roger Quadros <rogerq@xxxxxx> [150624 05:21]:
> On Wed, 24 Jun 2015 05:09:39 -0700
> Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> >
> > My take is we should only use regmap for the scm_conf area
> > in general.
>
> +1
>
> should we get rid of dra7_ctrl_core and dra7_ctrl_general?
> or move them to scm node?

Well at least move them. And if there are clear dedicated
register ranges there claimed only by a single device driver,
then those drivers should be just regular loadable driver
modules doing of_ioremap on the range. And in that case they
can be removed.

We have examples of both in dra7.dtsi, pbias_regulator using
the scm_conf via syscon, and then dra7_pmx_core ioremapping
a dedicated register range. So unless there are other messy
register ranges like the scm_conf area then there should not
be need for other syscon areas.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/