Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

From: Sanchayan Maity
Date: Wed Jun 24 2015 - 05:47:30 EST


On 15-06-24 10:37:43, Srinivas Kandagatla wrote:
>
>
> On 24/06/15 06:19, maitysanchayan@xxxxxxxxx wrote:
> >I just tested it without the "select REGMAP_MMIO" and it works just fine.
> You just got lucky in this case, as REGMAP_MMIO is getting selected
> somewhere else.
>
> Drivers should directly select the dependecies. In this case this driver
> actually is going to use REGMAP_MMIO, so keeping it selected is the right
> thing.

Yes, you are right. Checking the .config file shows that this is enabled even
with the explicit selection removed in my driver's kconfig.

Sorry about missing that Stefan and Srinivas.

- Sanchayan.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/