Re: [PATCH] SDHCI: Change AMD SDHCI quirk application scope

[Wan ZongShun]

2015-06-05 17:20 GMT+08:00 Borislav Petkov <bp@xxxxxxxxx>:
> On Fri, Jun 05, 2015 at 09:37:09AM +0800, Wan ZongShun wrote:
>> Boris, I means I put this KERCZ Mircro in pci_ids.h, and I also will
>> send the other patch to instead the following '0x790b' of codes. I
>> think it is reasonable, right?
>
> No, it means two things:
>
> * why does it contain KERNCZ? What does that mean?

The KERNCZ is new AMD SB/FCH generation name, like HUDSON2 is old FCH
generation.
We will adopt 0x790b as device ID since from this KERNCZ gereration.

>
> * #define PCI_DEVICE_ID_AMD_<better_name>_SMBUS 0x790b should be in
> drivers/mmc/host/sdhci-pci.c as it is used only there.


The i2cpiix4.c driver and eMMC driver both will use this device ID
macro, Do you think I should submit two patches synchronously? like
patch1: change i2cpiix4 driver to use PCI_DEVICE_ID_AMD_KERNCZ_SMBUS,
patch2: for eMMC quirk in sdhci-pci.c?

And then the PCI_DEVICE_ID_AMD_KERNCZ_SMBUS can be go into pci ids.h?

>
> Thanks.
>
> --
> Regards/Gruss,
>     Boris.
>
> ECO tip #101: Trim your mails when you reply.
> --



-- 
Wan ZongShun.
www.mcuos.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/