On Wed, May 27, 2015 at 02:03:38PM -0500, Aravind Gopalakrishnan wrote:
+static u32 amd_get_num_nodes(void)So we already do that (and more) in amd_get_topology(). I'm thinking
+{
+ u32 nodes = 1;
+
+ if (cpu_has_topoext) {
+ u32 ecx;
+
+ ecx = cpuid_ecx(0x8000001e);
+ nodes = ((ecx >> 8) & 7) + 1;
+ } else if (static_cpu_has(X86_FEATURE_NODEID_MSR)) {
+ u64 value;
+
+ rdmsrl(MSR_FAM10H_NODE_ID, value);
+ nodes = ((value >> 3) & 7) + 1;
+ }
you should take this function out of the CONFIG_X86_HT ifdeffery (also
in its caller amd_detect_cmp()) and you should save "nodes" in a local
static variable called nodes_per_processor and a small accessor called
amd_get_nodes_cnt() should return it. Similar to amd_get_nb_id().
Don't forget to add a comment explaning what that nodes_per_processor
means.
And then amd_mce_inj.c will simply use it instead of duplicating that
information here.
Please do that in 2 pre-patches.
+WARNING: quoted string split across lines
+ if (!(val & BIT(27))) {
+ pr_err("%s: BIOS not setting D18F3x44[NbMcaToMstCpuEn]."
+ "Doing that here\n", __func__);
#99: FILE: drivers/edac/mce_amd_inj.c:260:
+ pr_err("%s: BIOS not setting D18F3x44[NbMcaToMstCpuEn]."
+ "Doing that here\n", __func__);
Do integrate checkpatch.pl into your workflow. It is sometimes right.