Re: [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

From: Bhuvanchandra DV
Date: Fri May 29 2015 - 06:11:14 EST


Hello Jakub,

On 05/29/2015 03:34 PM, Jakub KiciÅski wrote:
On Fri, 29 May 2015 13:35:53 +0530, Bhuvanchandra DV wrote:
The LPUART does not provide manual control of RTS/CTS signals,
those can only be controlled by the hardware directly. Therefore
manual control of those signals through mctrl can not be provided.
The current implementation enables/disables the automatic control,
which is not what mctrl should do, hence remove the incorrect
implementation.

Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@xxxxxxxxxxx>

Now that the functions do nothing there is probably no point in keeping
separate lpuart/lpuart32 variants.
Agreed, will update it accordingly.

Thanks! for pointing this.


Best regards,
Bhuvan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/